[Help] Button Menu Bug

[acid_buRn]

Ive run into some trouble with my button menu.
It works and all, But when I click the button to activate the hack, It turn on, Then turns straight off again.

Here is the AddButton && RenderButton function:

void AddButton(int bnum, char *bcaption, int bx, int by, int bw, int bh )
{
     Button[bnum].num       = bnum;
     Button[bnum].caption   = bcaption;
     Button[bnum].x         = bx;
     Button[bnum].y         = by;
     Button[bnum].w         = bw;
     Button[bnum].h         = bh;
     Button[bnum].clicked   = false;
}

void RenderButton(int butnum)
{
     int mw = Button[butnum].x + Button[butnum].w;
     int mh = Button[butnum].y + Button[butnum].h;

	 //Defualt apperance
	 DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Red,g_pDevice);
	 PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);

	 POINT cur;
     GetCursorPos( &cur );

	 //if the mouse coords are the same as the buttons coords
      if ( cur.x > Button[butnum].x &&  cur.x < mw && cur.y > Button[butnum].y && cur.y < mh )
	  {
		   DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Blue, g_pDevice);
		   PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);

		  //if mouse button is clicked
		   if ( GetAsyncKeyState( VK_LBUTTON )&1) 
		   {
				Button[butnum].clicked = !Button[butnum].clicked;
			}
	  }

	  if ( Button[butnum].clicked )
	  {
		  DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Green, g_pDevice);
		  PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);
	  }
}

And the usage of the button:

if ( Button[1].clicked ) 
		//HackOn
else
               //HackOff

Im really stuck here. And dont know whats wrong.
Help me please!!

Thanks,
acid

[Freeheadshot]

Try this:

void AddButton(int bnum, char *bcaption, int bx, int by, int bw, int bh )
{
     Button[bnum].num       = bnum;
     Button[bnum].caption   = bcaption;
     Button[bnum].x         = bx;
     Button[bnum].y         = by;
     Button[bnum].w         = bw;
     Button[bnum].h         = bh;
     Button[bnum].clicked   = false;
}
#define KEY_DOWN(vk_code) ((GetAsyncKeyState(vk_code) & 0x8000) ? 1 : 0)
void RenderButton(int butnum)
{
     int mw = Button[butnum].x + Button[butnum].w;
     int mh = Button[butnum].y + Button[butnum].h;

	 //Defualt apperance
	 DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Red,g_pDevice);
	 PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);

	 POINT cur;
     GetCursorPos( &cur );

	 //if the mouse coords are the same as the buttons coords
      if ( cur.x > Button[butnum].x &&  cur.x < mw && cur.y > Button[butnum].y && cur.y < mh )
	  {
		   DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Blue, g_pDevice);
		   PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);

		  //if mouse button is clicked
		   if ( KEY_DOWN( VK_LBUTTON )) 
		   {
				Button[butnum].clicked = !Button[butnum].clicked;
			}
	  }

	  if ( Button[butnum].clicked )
	  {
		  DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Green, g_pDevice);
		  PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);
	  }
}

-Freeheadshot

[acid_buRn]

Originally Posted by Freeheadshot

Try this:

void AddButton(int bnum, char *bcaption, int bx, int by, int bw, int bh )
{
     Button[bnum].num       = bnum;
     Button[bnum].caption   = bcaption;
     Button[bnum].x         = bx;
     Button[bnum].y         = by;
     Button[bnum].w         = bw;
     Button[bnum].h         = bh;
     Button[bnum].clicked   = false;
}
#define KEY_DOWN(vk_code) ((GetAsyncKeyState(vk_code) & 0x8000) ? 1 : 0)
void RenderButton(int butnum)
{
     int mw = Button[butnum].x + Button[butnum].w;
     int mh = Button[butnum].y + Button[butnum].h;

	 //Defualt apperance
	 DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Red,g_pDevice);
	 PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);

	 POINT cur;
     GetCursorPos( &cur );

	 //if the mouse coords are the same as the buttons coords
      if ( cur.x > Button[butnum].x &&  cur.x < mw && cur.y > Button[butnum].y && cur.y < mh )
	  {
		   DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Blue, g_pDevice);
		   PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);

		  //if mouse button is clicked
		   if ( KEY_DOWN( VK_LBUTTON )) 
		   {
				Button[butnum].clicked = !Button[butnum].clicked;
			}
	  }

	  if ( Button[butnum].clicked )
	  {
		  DrawBox(Button[butnum].x, Button[butnum].y,  Button[butnum].w,  Button[butnum].h, Black, Green, g_pDevice);
		  PrintText(pFont, Button[butnum].x + 15, Button[butnum].y + 3, White, Button[butnum].caption);
	  }
}

-Freeheadshot

Thanks for the help, But it didnt work.
I can now hold the button for the hack to work, But once i let go, The hack turns off D:

Any other ideas..?

[Freeheadshot]

Justf think about it by yourslef it have to do with the buttons .... now try abit around

[Stevepwns]

well, that code looks strangly like the source i released, heres the rest of it from the original post.

Button Menu D3D9

what i did to select the action once its is

void ClickButton(int btn)
{
if (Button[btn].clicked)
}
switch (btn)
{
case 1:
//do something
Breake;
}
}
else
{
//do something else
}
}


this proxy coode you can figure it out

[disavow]

Happens often when you nest a GetAsyncKeyState within a lot of jmp's such as this.
I'm guessing your iterating through this check several times.
Free up the hotkey check.

[Tatez]

Add a '& 1' or something. If all else fails, you may have to resort to a very short Sleep(), maybe about 200 milliseconds long.

Oh yea, sleeping in rendering.
Wisdom from the best >_>;

[disavow]

Originally Posted by SEGnosis

Oh yea, sleeping in rendering.
Wisdom from the best >_>;

Sleep(200) for 5fps
Gotta love these cats.

[Tatez]

Originally Posted by SEGnosis

Oh yea, sleeping in rendering.
Wisdom from the best >_>;

I've done that in a menu before and it was barely noticeable. Give it a try. I said, "If all else fails". That's definitely not a plan A. I'm 100% aware that sleeping in a DirectX hook pauses the game.

[Stevepwns]

define KEY_DOWN.......was your problem, Leave the menu how i coded it originally, it works fine how it is.

[acid_buRn]

Originally Posted by Stevepwns

define KEY_DOWN.......was your problem, Leave the menu how i coded it originally, it works fine how it is.

I am using it the way it was released.
If it was working fine, I wouldnt have had to post this thread :P

[topblast]

Originally Posted by acid_buRn

I am using it the way it was released.
If it was working fine, I wouldnt have had to post this thread :P

Maybe i can help u. It the same problem with my tab menu but i found how to fix it.

[Stevepwns]

since i wrote it and still use it( slightly altered) i need to see how your using it in order to see whats being done wrong, send me a pm with your source and ill go over it for you, Im ssure it can be fixed easily. Ill get you squared away or Ill just show you how i do mine so you can have a working menu you can use with out any problems

[topblast]

if(keydown(bla bla){
       if(keyup)
                Button.value=!button.value;
       keyup=false;
}else
       keyup=true;

THAT HOW U DO THINGSSSSSSSSSSS

[learn_more]

no, the if(keyup) will never fire, since the key isnt down anymore when it's up.